Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace grep in favor of sed for upgrade script tests #654

Merged
merged 1 commit into from May 20, 2020
Merged

Replace grep in favor of sed for upgrade script tests #654

merged 1 commit into from May 20, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Replace grep in favor of sed for upgrade script tests

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

perk-sumo
perk-sumo approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@perk-sumo perk-sumo added this to the v1.0 milestone May 20, 2020
@perk-sumo perk-sumo merged commit b1d068d into master May 20, 2020
@perk-sumo perk-sumo deleted the drosiek-test-fix-mac branch May 20, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@frankreno frankreno Awaiting requested review from frankreno

@samjsong samjsong Awaiting requested review from samjsong

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sumo-drosiek @perk-sumo