Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of assert_equal in test files #67

Merged
merged 2 commits into from Jul 11, 2019
Merged

Conversation

yuting-liu
Copy link
Contributor

The correct order for assert_equal should be assert_equal expected, actual.
The order is incorrect for some test files.

maimaisie
maimaisie previously approved these changes Jul 11, 2019
samjsong
samjsong previously approved these changes Jul 11, 2019
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuting!

@yuting-liu yuting-liu dismissed stale reviews from samjsong and maimaisie via aeddfa5 July 11, 2019 21:35
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah sorry, I enabled the option to "dismiss reviews" when a new commit is pushed for security reasons

@yuting-liu
Copy link
Contributor Author

@samjsong Thanks. Just tried to ask your approval again 🤦‍♀

@yuting-liu yuting-liu merged commit d07b8e7 into master Jul 11, 2019
@yuting-liu yuting-liu deleted the yuting-fix-test branch July 11, 2019 21:51
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants