Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingest retry succeeded logs and expose param in values file #671

Merged
merged 2 commits into from May 26, 2020
Merged

ingest retry succeeded logs and expose param in values file #671

merged 2 commits into from May 26, 2020

Conversation

vsinghal13
Copy link
Contributor

ingest retry succeeded logs and expose param in values file to turn off the filter

Description

Fixes #621

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 added this to the v1.1 milestone May 21, 2020
sumo-drosiek
sumo-drosiek approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely feature 👍

frankreno
frankreno approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsinghal13 vsinghal13 merged commit 5add448 into master May 26, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-add-flag-filter-plugin branch May 26, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Allow [warn] fluentd log line of the form retry succeded. chunk_id=xxxx
4 participants
@vsinghal13 @frankreno @samjsong @sumo-drosiek