Filter list of control-plane app metrics #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
frankreno,
vsinghal13,
perk-sumo and
samjsong
and removed request for
frankreno and
vsinghal13
sumo-drosiek
force-pushed
the
drosiek-control-plane
branch
from
94a0516
to
dabdef5
Compare
sumo-drosiek
changed the title
frankreno
approved these changes
Jun 1, 2020
deploy/helm/sumologic/values.yaml
Outdated
| writeRelabelConfigs: | ||
| - action: keep | ||
| regex: coredns | ||
| sourceLabels: [job] | ||
| - action: keep |
There was a problem hiding this comment.
Just curious on the reason to have 2 keep blocks vs something like this:
- url: http://$(CHART).$(NAMESPACE).svc.cluster.local:9888/prometheus.metrics.control-plane.coredns
writeRelabelConfigs:
- action: keep
regex: coredns;coredns_cache_(size|(hits|misses)_total)|coredns_dns_request_duration_seconds_(count|sum)|coredns_(dns_request|dns_response_rcode|forward_request)_count_total|process_(cpu_seconds_total|open_fds|resident_memory_bytes)
sourceLabels: [job,__name__]
There was a problem hiding this comment.
It's more clear in my personal opinion :)
I also wasn't sure how exactly works the writeRelabelConfig for such construct, but I read the docs and I don't see any risk related to that.
I can change it to be more compressed and to keep convention
There was a problem hiding this comment.
The only reason I brought it up was just consistency like we do the other rules. I have no problem with doing it this way either.
There was a problem hiding this comment.
Convention is important :D
I updated PR, need to re-test it :)
sumo-drosiek
force-pushed
the
drosiek-control-plane
branch
from
1bf687c
to
8d10bed
Compare
sumo-drosiek
force-pushed
the
drosiek-control-plane
branch
from
f95cf23
to
e485707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restrict coredns and etcd metrics
Testing performed