Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump terraform providers #714

Merged
merged 2 commits into from Jun 8, 2020
Merged

Bump terraform providers #714

merged 2 commits into from Jun 8, 2020

Conversation

sumo-drosiek
Copy link
Contributor

  • Bump providers versions
  • Bump terraform client version due to bugs
  • Update terraform scripts due to deprecation warnings
  • Add one new test and update previous ones regarding aboves
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

 * Bump providers versions
 * Bump terraform client version due to bugs
 * Update teraaform scripts due to deprecation warnings
 * Add one new test and update previous ones regarding aboves
@sumo-drosiek sumo-drosiek added this to the v1.1 milestone Jun 5, 2020

Examples:
- "${test}" will be printed as `test`
- "test" will be printed as `"test"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to deprecation of "${variable}" in favor of variable

@@ -52,7 +52,7 @@ sumologic:
# config_context_auth_info:
# config_context_cluster:
token: "${file(\"/var/run/secrets/kubernetes.io/serviceaccount/token\")}"
# load_config_file:
load_config_file: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am also facing same issue as it is being running via github action workflow

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this version of TF provider contains the fix for endpoint issue on prod right?

Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is great! @samjsong yes, tf provider v.2.0.3 contains your fix

@syedrakib
Copy link

Looking forward to the fix for hashicorp/terraform-provider-kubernetes#821

@sumo-drosiek
Copy link
Contributor Author

sumo-drosiek commented Jun 8, 2020

@syedrakib, setting load_config_file to false solves http://localhost/api/v1/namespaces/my-ns: dial tcp 127.0.0.1:80: connect: connection refused for us. At least I didn't spot the issue again yet.

@sumo-drosiek sumo-drosiek merged commit 36bc4e4 into master Jun 8, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-upgrade-terraform branch June 8, 2020 07:47
@ravitomardevops
Copy link

Does kubernets provider support load_config_file to false ? not ,please check official page https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs ,Now how to deal with it ?

@ravitomardevops
Copy link

Looking forward to the fix for hashicorp/terraform-provider-kubernetes#821

@syedrakib How you have resolved it , i am also facing same issue .Please help

@sumo-drosiek
Copy link
Contributor Author

@ravitomardevops What sumologic kubernetes collection version do you use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants