Add missing metrics to fluentd #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
changed the title
|
I got:
I tested it on empty vagrant environment Regarding that, I'm going to disable those metrics by default |
|
The increase makes sense as I assume it is by plugin ID, which adds a good amount of cardinality to the data. |
frankreno
approved these changes
Jun 8, 2020
| {{- end }} | ||
| @include buffer.output.conf | ||
| </buffer> | ||
| @type copy |
There was a problem hiding this comment.
Why did we switch to copy?
There was a problem hiding this comment.
| type counter | ||
| desc The total number of incoming records | ||
| <labels> | ||
| tag ${tag} |
There was a problem hiding this comment.
This is what leads to very high cardinality in the case of logs. Each tag is the full file path for the container log, and it includes the container and pod ID, so it can drastically increase the metrics cardinality here.
sumo-drosiek
force-pushed
the
drosiek-fluentd-prometheus-metrics
branch
2 times, most recently
from
879cb67
to
d9bb74f
Compare
perk-sumo
force-pushed
the
drosiek-fluentd-prometheus-metrics
branch
from
9d1eecd
to
ebfbc60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
fluentd_input_status_num_records_totalandfluentd_output_status_num_records_totalmetricsFixes #717
Testing performed