Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overview image to main repo README #72

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

rvmiller89
Copy link
Contributor

@rvmiller89 rvmiller89 commented Jul 15, 2019

Thought this was a nice overview image, and might be worth adding it to our currently blank repo README. I'm fine with moving this around later as we see fit.

To see the change:

Screen Shot 2019-07-15 at 11 24 36 AM

@rvmiller89 rvmiller89 requested a review from samjsong July 15, 2019 18:24
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Thanks Ryan for adding, and thanks Frank for making!

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and awesome!

@rvmiller89 rvmiller89 merged commit 51126ab into master Jul 16, 2019
@rvmiller89 rvmiller89 deleted the rmiller-add-overview-image-readme branch July 16, 2019 01:40
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
* Revert "Enable ad for dv-sumologic role (SumoLogic#71)"

This reverts commit a8f4fdd.

* what about hard coding it?

* capitalize com per microsoft docs

* Comment out oudn

* Revert "Comment out oudn"

This reverts commit 090ec029a1c6fd6e3144cef5a944650525d7cd2c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants