Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential tf race confition #722

Merged
merged 2 commits into from Jun 10, 2020
Merged

Conversation

sumo-drosiek
Copy link
Contributor

Description

Fix potential tf race confition
Fixes #720

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek
Copy link
Contributor Author

This PR is made on the top of the #721

@sumo-drosiek sumo-drosiek changed the base branch from master to drosiek-split-tf June 9, 2020 09:22
@sumo-drosiek sumo-drosiek added this to the v1.1 milestone Jun 9, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good fix!

Base automatically changed from drosiek-split-tf to master June 10, 2020 06:12
@perk-sumo perk-sumo force-pushed the drosiek-fix-potential-tf-race branch from c2d688b to 84532ad Compare June 10, 2020 06:17
@perk-sumo perk-sumo merged commit a170917 into master Jun 10, 2020
@perk-sumo perk-sumo deleted the drosiek-fix-potential-tf-race branch June 10, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Race Condition in Setup
4 participants