Fix helm chart requirements conditions #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
frankreno,
samjsong,
vsinghal13 and
perk-sumo
Multiple conditions works as below: 1. If first value is specified, it decides if the requirement is installed or not 2. If it's not, the second is taken under consideration
sumo-drosiek
force-pushed
the
drosiek-fix-chart-req-conditions
branch
from
76bafcc
to
dbd5704
Compare
perk-sumo
reviewed
Jun 16, 2020
perk-sumo
reviewed
Jun 16, 2020
Co-authored-by: Marcin Stozek <58700054+perk-sumo@users.noreply.github.com>
perk-sumo
reviewed
Jun 16, 2020
perk-sumo
reviewed
Jun 16, 2020
Co-authored-by: Marcin Stozek <58700054+perk-sumo@users.noreply.github.com>
|
https://helm.sh/docs/topics/charts/#tags-and-condition-fields-in-dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple conditions works as below:
due to point 1 we should change order of conditions and comment the
prometheus-operator.enabledso for prometheus:
If
prometheus-operator.enabledis not set, themetrics.enableddecides if we enable prometheus or not, otherwiseprometheus-operator.enabledis decisiveTesting performed