-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUMO-113170 Support different k8s api versions #74
Conversation
yuting-liu
commented
Jul 16, 2019
- Add support for different k8S api versions with multiple clients.
- Add unit tests.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you haven't, let's make sure to run the plugin with the beta1 api version and check if events are getting ingested to Sumo. I feel like because we are stubbing all client methods in the unit tests, we are not really testing the logic "given a different API version it will call different endpoint". Technically, if you set beta1 version in the config param in a unit test and call mock_get_events
with the v1 file, it would still succeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment. +1 to Maisie's comment that we should try testing to see how it works when deployed
66dc9c7
to
997f583
Compare
Already tested the plugin, with api version
Here is what we got from watch:
So this do watch the correct resource with correct api version. |
is this log ingested in Sumo? |
@maimaisie Yea, the log is ingested in Sumo. |
* Remove hard coded enable_ad * Enable ad * Format