Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indents on FluentDs extraEnvVars and extraVolumes #757

Merged
merged 1 commit into from Jul 3, 2020
Merged

Fix indents on FluentDs extraEnvVars and extraVolumes #757

merged 1 commit into from Jul 3, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Fixes for #681

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo requested review from vsinghal13 and a team July 2, 2020 16:36
@perk-sumo perk-sumo added the bug Something isn't working label Jul 2, 2020
@perk-sumo perk-sumo added this to the v1.1 milestone Jul 2, 2020
frankreno
frankreno approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo merged commit 17f0505 into master Jul 3, 2020
@perk-sumo perk-sumo deleted the perk-fix-extraenvs-indents branch July 3, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@perk-sumo @frankreno