fix automatic setup script command in deploy README #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-sumo
reviewed
Jul 16, 2019
| @@ -66,7 +66,7 @@ This approach requires access to the Sumo Logic Collector API. It will create a | |||
|
|
|||
| ```sh | |||
| curl -s https://raw.githubusercontent.com/SumoLogic/sumologic-kubernetes-collection/master/deploy/kubernetes/setup.sh \ | |||
| | bash -s [-c collector-name] [-k cluster-name] <api-endpoint> <access-id> <access-key> | |||
| | bash -s - [-c collector-name] [-k cluster-name] [-n namespace] <api-endpoint> <access-id> <access-key> | |||
There was a problem hiding this comment.
why do we need the extra bar here?
There was a problem hiding this comment.
I believe the extra bar tells the bash command that the result from the pipe stdin should be inserted in the command there. Otherwise the other arguments -c -k -n are interpreted as arguments to the bash command
lei-sumo
approved these changes
Jul 16, 2019
rvmiller89
approved these changes
Jul 17, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.