Make imagePullPolicy and latest tag explicit for now

[rvmiller89]

Until we start tagging our sumologic/kubernetes-fluentd releases, we should be explicit about the Always imagePullPolicy and 0.0.0 tag.

Once we start tagging, we can change this to:

image: sumologic/kubernetes-fluentd:v1.blah
imagePullPolicy: IfNotPresent

[samjsong]

Since technically we tag our release with version 0.0.0, should we explicitly pull version 0.0.0 until we start tagging with actual versions? This would help remind us not to use the latest tag in the future

[rvmiller89]

Do we overwrite the previous tagged image 0.0.0 each time? I guess I don't really know how tags work. Should we be incrementing instead, like 0.0.1, 0.0.2, etc. so that each version has a unique tag?

[samjsong]

Yeah since we didn't start tagging anything we've been overriding the version 0.0.0 every time we push something new... I believe the plan was to start incrementing in that way once events and enhanced metadata were complete, starting with 1.0.0

[samjsong]

In retrospect it would've been better to start incrementing much sooner, so we have a history of changes...

[lei-sumo]

lgtm in case you tested it out.

[blaise-sumo]

FWIW, images can have multiple tags and it is really nice if at least one of them is the first 7 or 8 chars of the git commit Sha.

…

On Tue, Jul 16, 2019, 5:32 PM Lei Huang ***@***.***> wrote: ***@***.**** approved this pull request. lgtm in case you tested it out. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#77?email_source=notifications&email_token=ALSRZWL3OUGPS3VTJ6CPUR3P7ZSB3A5CNFSM4IEIUY62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6UUXPQ#pullrequestreview-262753214>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALSRZWN47DUKVBPQ37WR3HTP7ZSB3ANCNFSM4IEIUY6Q> .

[frankreno]

LGTM. Once we get into a proper release cycle, it would be good to include part of the SHA as @blaise-sumo points out its pretty standard. We will also need to udpate ImagePullPolicy to ifNotPresent once we do full release cycles.