Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused sumologic.traces.endpoint key (clean up otelcol conf after the #778 merge) #779

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek
Copy link
Contributor

Can we split this enormous line to multiple lines to better track the git changes?

@perk-sumo perk-sumo added this to the v1.1 milestone Jul 20, 2020
@perk-sumo perk-sumo force-pushed the perk-tracing-env-url-cleanup branch from 40e5b9c to 3604ce5 Compare July 24, 2020 14:29
@perk-sumo perk-sumo requested a review from pmm-sumo July 24, 2020 14:29
Copy link
Contributor

@mat-rumian mat-rumian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo force-pushed the perk-tracing-env-url-cleanup branch 4 times, most recently from 82a4ea0 to abff23d Compare July 27, 2020 10:34
@perk-sumo perk-sumo changed the title Clean up otelcol conf after the #778 merge Remove the unused sumologic.traces.endpoint key (clean up otelcol conf after the #778 merge) Jul 27, 2020
@perk-sumo perk-sumo force-pushed the perk-tracing-env-url-cleanup branch from abff23d to f709ec7 Compare July 27, 2020 11:59
@perk-sumo perk-sumo force-pushed the perk-tracing-env-url-cleanup branch from f709ec7 to 21704d8 Compare July 27, 2020 12:35
@perk-sumo
Copy link
Contributor Author

It's smoke tested and ready for review /cc @pmm-sumo

Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo merged commit 21704d8 into master Jul 27, 2020
@perk-sumo perk-sumo deleted the perk-tracing-env-url-cleanup branch July 27, 2020 12:48
@sumo-drosiek
Copy link
Contributor

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants