Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodeSelector for setup job #783

Merged
merged 2 commits into from Sep 11, 2020
Merged

add nodeSelector for setup job #783

merged 2 commits into from Sep 11, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Solves #747

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 added this to the v1.3 milestone Jul 17, 2020
@vsinghal13 vsinghal13 linked an issue Jul 17, 2020 that may be closed by this pull request
Support setting nodeselector for job and pods created in values.yaml #747
Closed
@vsinghal13 vsinghal13 requested a review from a team July 17, 2020 00:39
frankreno
frankreno approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsinghal13 vsinghal13 merged commit 7fb1775 into master Sep 11, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-node-selector-setup-job-pod branch September 11, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Support setting nodeselector for job and pods created in values.yaml
5 participants
@vsinghal13 @frankreno @samjsong @sumo-drosiek @perk-sumo