Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add priority class to fluentd sts #784

Merged
merged 4 commits into from Sep 11, 2020
Merged

Add priority class to fluentd sts #784

merged 4 commits into from Sep 11, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Solves #732

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 linked an issue Jul 17, 2020 that may be closed by this pull request
Expose priority class for resources deployed by k8s collection #732
Closed
@vsinghal13 vsinghal13 added this to the v1.3 milestone Jul 17, 2020
@vsinghal13 vsinghal13 requested review from a team, frankreno, samjsong and sumo-drosiek and removed request for a team July 17, 2020 17:33
frankreno
frankreno approved these changes Jul 18, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bergerx
Copy link

bergerx commented Jul 18, 2020

This one is marked woth "Solves #732". I dont think this one covers all the resources deployed by the chart.

@vsinghal13
Copy link
Contributor Author

This one is marked woth "Solves #732". I dont think this one covers all the resources deployed by the chart.

This PR covers priority class for fluentd sts. For faclo, prometheus and fluent-bit resources, the same functionality if present in the sub-charts can be used directly.

sumo-drosiek
sumo-drosiek reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add it to the otelcol as well?

sumo-drosiek
sumo-drosiek approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@vsinghal13 vsinghal13 closed this Sep 11, 2020
@vsinghal13 vsinghal13 reopened this Sep 11, 2020
@vsinghal13 vsinghal13 merged commit 66d7b73 into master Sep 11, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-priority-class-pods branch September 11, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Expose priority class for resources deployed by k8s collection
6 participants
@vsinghal13 @bergerx @frankreno @samjsong @sumo-drosiek @perk-sumo