Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable file persistence by default #816

Merged
merged 2 commits into from Aug 4, 2020
Merged

Enable file persistence by default #816

merged 2 commits into from Aug 4, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Aug 3, 2020 •
edited

Description

Enabled fluentd file persistence by default along with a warning message if the property fluentd.persistence.enabled is set to false

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 added this to the v1.2 milestone Aug 3, 2020
@vsinghal13 vsinghal13 linked an issue Aug 3, 2020 that may be closed by this pull request
Enable file persistence with auto provisioning for buffer by default. #774
Closed
@vsinghal13 vsinghal13 requested review from a team, frankreno, samjsong, perk-sumo and sumo-drosiek and removed request for a team August 3, 2020 23:43
frankreno
frankreno approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sumo-drosiek
sumo-drosiek approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but related question

Do we want to enable persistence for prometheus?

@vsinghal13
Copy link
Contributor Author

LGTM, but related question

Do we want to enable persistence for prometheus?

As discussed, we won't be enabling persistence on prometheus.

@vsinghal13 vsinghal13 merged commit 0a488a9 into master Aug 4, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-enable-file-persistence branch August 4, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@samjsong samjsong Awaiting requested review from samjsong

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Enable file persistence with auto provisioning for buffer by default.
3 participants
@vsinghal13 @frankreno @sumo-drosiek