Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customLabels for kube-state-metrics #824

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Add customLabels for kube-state-metrics #824

merged 2 commits into from
Aug 10, 2020

Conversation

vsinghal13
Copy link
Contributor

Description
  • Add custom labels for kube-state-metrics.
  • Fixed the indentation for prometheus-node-exporter and kube-state-metrics
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 added this to the v1.2 milestone Aug 8, 2020
frankreno
frankreno approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsinghal13 vsinghal13 merged commit b06bb77 into master Aug 10, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-kube-state-metrics-custom-labels branch August 10, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@samjsong samjsong Awaiting requested review from samjsong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsinghal13 @frankreno @sumo-drosiek