Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use variables in documentation for additional prometheus metrics #851

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Use variables in documentation for additional prometheus metrics. The current service name used in the docs is out of date

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested review from a team, samjsong, vsinghal13 and pmalek-sumo and removed request for a team August 24, 2020 17:56
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sumo-drosiek sumo-drosiek added the documentation documentation label Aug 27, 2020
@sumo-drosiek sumo-drosiek merged commit 4019fa7 into master Aug 27, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-fix-add-prom-metr-svc-name branch August 27, 2020 06:54
@perk-sumo perk-sumo added this to the v1.2 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants