Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrap metrics from pods basing on annotations #852

Merged
merged 2 commits into from Sep 14, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Scrap metrics from pods basing on annotations

rel: prometheus-operator/kube-prometheus#16 (comment)
rel: prometheus/prometheus#4131

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested review from frankreno, samjsong and a team August 26, 2020 12:25
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Left just one nit comment

deploy/docs/additional_prometheus_configuration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

* Update additional_prometheus_configuration.md

Co-authored-by: Sam Song <ssong@sumologic.com>
@sumo-drosiek sumo-drosiek merged commit 15d0fca into master Sep 14, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-prom-scrap-annotations branch September 14, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants