Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable fluentd persistence by default #858

Merged
merged 2 commits into from
Aug 27, 2020
Merged

disable fluentd persistence by default #858

merged 2 commits into from
Aug 27, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

perk-sumo
perk-sumo approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we explain it in the release notes and change it back in 2.0.
LGTM 👍

@perk-sumo perk-sumo added this to the v1.2 milestone Aug 27, 2020
frankreno
frankreno approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsinghal13 vsinghal13 merged commit 767b48f into master Aug 27, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-patch-1 branch August 27, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsinghal13 @frankreno @perk-sumo