Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump documentation version to 1.2 #864

Merged
merged 3 commits into from Aug 28, 2020
Merged

Bump documentation version to 1.2 #864

merged 3 commits into from Aug 28, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added the documentation documentation label Aug 28, 2020
@perk-sumo perk-sumo added this to the v1.2 milestone Aug 28, 2020
@perk-sumo perk-sumo marked this pull request as ready for review August 28, 2020 15:09
@perk-sumo perk-sumo changed the title Add FluentD version info to documentation Bump documentation version to 1.2 Aug 28, 2020
frankreno
frankreno approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo mentioned this pull request Aug 28, 2020
Closed
3 tasks
sumo-drosiek
sumo-drosiek reviewed Aug 28, 2020
View reviewed changes
deploy/README.md Outdated Show resolved Hide resolved
sumo-drosiek
sumo-drosiek approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit 🎸

@perk-sumo @sumo-drosiek
Update deploy/README.md (0.17.1 -> 0.17.4)
811be0e 
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@perk-sumo perk-sumo merged commit 849487c into master Aug 28, 2020
@perk-sumo perk-sumo deleted the doc-updates-for-release-1.2 branch August 28, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@vsinghal13 vsinghal13 vsinghal13 approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@perk-sumo @frankreno @samjsong @vsinghal13 @sumo-drosiek