Upgrade Dockerfile fluentd to v1.6.2 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimaisie
reviewed
Jul 24, 2019
| @@ -64,6 +64,7 @@ ENV VERIFY_SSL "true" | |||
|
|
|||
| RUN mkdir -p /fluentd/conf.d | |||
|
|
|||
| COPY ./fluent.conf /fluentd/conf.d/fluent.conf | |||
| COPY ./fluent.conf /fluentd/etc/ | |||
| COPY entrypoint.sh /bin/ | |||
There was a problem hiding this comment.
should we test this with a local image first to see if helps with the current bug? or do you think we should upgrade regardless?
There was a problem hiding this comment.
What are we trying to do here with the upgrade? Is this an alpine or debian build? I remember we had some issue with debian build
There was a problem hiding this comment.
Yeah, I'm testing currently to see if it helps with the other issue. But I think we should merge this regardless. I have verified fluentd is starting correctly.
@lei-sumo We're upgrading to the latest release of the Alpine docker image from FluentD, since there have been some bug fixes since 1.4.2: https://github.com/fluent/fluentd/blob/master/CHANGELOG.md
maimaisie
approved these changes
Jul 24, 2019
lei-sumo
approved these changes
Jul 24, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Co-authored-by: Mel Cone <mel.cone@nytimes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.