Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fixed kubeclient version 4.9.0 for fluent-plugin-enhance-k8s-meta… #870

Merged
merged 2 commits into from Aug 31, 2020
Merged

Use fixed kubeclient version 4.9.0 for fluent-plugin-enhance-k8s-meta… #870

merged 2 commits into from Aug 31, 2020

Conversation

perk-sumo
Copy link
Contributor

@perk-sumo perk-sumo commented Aug 31, 2020 •
edited

…data

Description

When newer version of kubeclient is used we get the following error:

Error: test: fetch_pod_metadata get labels(ReaderTest):
  WebMock::NetConnectNotAllowedError: Real HTTP connections are disabled. Unregistered request: GET http://localhost:8080/apis/api/extensions/v1beta1/namespaces/sumologic/replicasets/curl-byi-5bf5d48c57 with headers {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Host'=>'localhost:8080', 'User-Agent'=>'rest-client/2.1.0 (linux-gnu x86_64) ruby/2.5.1p57'}
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added this to the v1.2 milestone Aug 31, 2020
@sumo-drosiek
Copy link
Contributor

LGTM xD

pmalek-sumo
pmalek-sumo approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frankreno
frankreno approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek sumo-drosiek merged commit d67c9f7 into master Aug 31, 2020
@sumo-drosiek sumo-drosiek deleted the perk-use-fixed-kubeclient-version branch August 31, 2020 15:48
This was referenced Aug 31, 2020
Closed
Merged
@perk perk mentioned this pull request Sep 3, 2020
Merged
samjsong pushed a commit that referenced this pull request Sep 3, 2020
@perk-sumo @samjsong
Use fixed kubeclient version 4.9.0 for gems and docker (#870)
4dfc77f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@perk-sumo @sumo-drosiek @frankreno @pmalek-sumo