Don't scrape from headless services #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
requested review from
frankreno,
vsinghal13,
sumo-drosiek and
perk-sumo
|
Fixes #776 |
sumo-drosiek
reviewed
Sep 9, 2020
There was a problem hiding this comment.
I think thats the correct solution. We could eventually add additional label for scraping metrics
@perk thoughts?
|
Yeah, I think that works for now but let's fix it properly in |
perk-sumo
approved these changes
Sep 10, 2020
vsinghal13
approved these changes
Sep 10, 2020
|
If we change the labels now, will it be considered a breaking change? |
sumo-drosiek
requested changes
Sep 11, 2020
There was a problem hiding this comment.
Valid point from @vsinghal13
@pmalek-sumo could you verify that?
sumo-drosiek
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents prometheus double scraping fluentd pods by removing the annotations from headless services.
Testing performed