Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sumologic to sumo-make and add bash completion #902

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Rename sumologic to sumo-make and add bash completion #902

merged 1 commit into from
Sep 16, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Rename sumologic to sumomake and add bash completion

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

perk-sumo
perk-sumo reviewed Sep 16, 2020
View reviewed changes
vagrant/provision.sh Outdated Show resolved Hide resolved
perk-sumo
perk-sumo reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 for completion but let's talk a bit more on the sumomake vs sumo-make please :)

vagrant/provision.sh Outdated Show resolved Hide resolved
vagrant/scripts/sumomake-completion.sh Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek changed the title Rename sumologic to sumomake and add bash completion Rename sumologic to sumo-make and add bash completion Sep 16, 2020
perk-sumo
perk-sumo approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@perk-sumo perk-sumo merged commit 0df2530 into master Sep 16, 2020
@perk-sumo perk-sumo deleted the drosiek-vagrant-sumomake branch September 16, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sumo-drosiek @perk-sumo @pmalek-sumo @andrzej-stencel