Do not proxy kubernetes internal traffic #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
frankreno,
vsinghal13,
perk-sumo and
a team
sumo-drosiek
force-pushed
the
drosiek-fix-external-proxy
branch
from
460ebaf
to
66e53d8
Compare
|
Fixes #914 |
frankreno
reviewed
Sep 16, 2020
| @@ -32,6 +32,8 @@ sumologic: | |||
| ## proxy urls | |||
| httpProxy: "" | |||
| httpsProxy: "" | |||
| ## Exclude kubernetes internal traffic from proxy | |||
| noProxy: kubernetes.default.svc | |||
There was a problem hiding this comment.
Love this approach it is cleaner. Con is that if a customer has a different url where they customize the host in the TF kubernetes provider, they have to also update this. Any way to have one property to control both?
There was a problem hiding this comment.
Should the cluster endpoint be excluded from the proxy every time?
I can merge both of the config options in helm, but there will be no way to include the kubernetes url then (to proxy)
There was a problem hiding this comment.
Ahh ok fair point. In that case we can leave it
pmalek-sumo
approved these changes
Sep 17, 2020
sumo-drosiek
force-pushed
the
drosiek-fix-external-proxy
branch
from
66e53d8
to
0e017ce
Compare
sumo-drosiek
force-pushed
the
drosiek-fix-external-proxy
branch
from
b54a9f6
to
0e7947f
Compare
perk-sumo
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Do not proxy kubernetes internal traffic * Update terraform tests * Generate new 'setup-sumologic.yaml.tmpl' Co-authored-by: Travis CI <travis@travis-ci.org>
perk-sumo
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Do not proxy kubernetes internal traffic * Update terraform tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not proxy kubernetes internal traffic
Testing performed