New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor build Dockerfile #949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
requested review from
sumo-drosiek,
perk-sumo and
andrzej-stencel
September 24, 2020 11:08
perk-sumo
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
One minor thing about 7 spaces and not 6 before installed apps (curl
, g++
etc.) or gems.
perk-sumo
reviewed
Sep 24, 2020
deploy/docker/Dockerfile
Outdated
@@ -64,8 +70,8 @@ RUN apt-get update \ | |||
&& apt-get install -y --no-install-recommends libsnappy-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
&& apt-get install -y --no-install-recommends libsnappy-dev | |
&& apt-get install --yes --no-install-recommends \ | |
libsnappy-dev |
andrzej-stencel
approved these changes
Sep 24, 2020
sumo-drosiek
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gem install
s into less invocations&&
at the beginning of the line and equal indentation)Testing performed