Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build Dockerfile #949

Merged
merged 4 commits into from Sep 24, 2020
Merged

Refactor build Dockerfile #949

merged 4 commits into from Sep 24, 2020

Conversation

pmalek-sumo
Copy link
Contributor

  • aggregate gem installs into less invocations
  • unify formatting (&& at the beginning of the line and equal indentation)
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
One minor thing about 7 spaces and not 6 before installed apps (curl, g++ etc.) or gems.

deploy/docker/Dockerfile Outdated Show resolved Hide resolved
@@ -64,8 +70,8 @@ RUN apt-get update \
&& apt-get install -y --no-install-recommends libsnappy-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&& apt-get install -y --no-install-recommends libsnappy-dev
&& apt-get install --yes --no-install-recommends \
libsnappy-dev

@pmalek-sumo pmalek-sumo merged commit 9d36e5e into master Sep 24, 2020
@pmalek-sumo pmalek-sumo deleted the refactor-build-Dockerfile branch September 24, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants