Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename hpa metrics #965

Merged
merged 2 commits into from
Sep 30, 2020
Merged

rename hpa metrics #965

merged 2 commits into from
Sep 30, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Sep 29, 2020 •
edited
Loading

Description

The kube-state-metrics helm chart currently uses the v1.9.7 image which still uses hpa instead of horizontalpodautoscaler.

These will be renamed as part of v2.0.0 of kube-state-metrics.

v2.0.0 Alpha release notes: https://github.com/kubernetes/kube-state-metrics/releases

Ref PR: kubernetes/kube-state-metrics#1003

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

frankreno
frankreno approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - when we switch over to 2.0 we can adjust.

@vsinghal13 vsinghal13 merged commit 77d2268 into master Sep 30, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-patch-2 branch September 30, 2020 02:36
@perk-sumo perk-sumo added this to the v1.3 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@justrelax19 justrelax19 Awaiting requested review from justrelax19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsinghal13 @frankreno @perk-sumo