Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include description of otelcol Helm chart params #981

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

pmm-sumo
Copy link
Contributor

@pmm-sumo pmm-sumo commented Oct 5, 2020

Description

Adds docs for OpenTelemetry Collector-related params

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pmm-sumo !

@perk-sumo perk-sumo added this to the v1.3 milestone Oct 6, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts and add info about requirement for tracing being enabled for the account.
Other than that I'm 👍

deploy/helm/sumologic/README.md Outdated Show resolved Hide resolved
@pmm-sumo
Copy link
Contributor Author

pmm-sumo commented Oct 6, 2020

@perk-sumo resolved the conflicts and added a note

@perk-sumo perk-sumo merged commit 16a59c1 into master Oct 6, 2020
@perk-sumo perk-sumo deleted the otelcol-params-doc branch October 6, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants