Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receiver-mock: remove duplicated short flags for logs and metrics #194

Merged
merged 1 commit into from
Dec 20, 2021
Merged

receiver-mock: remove duplicated short flags for logs and metrics #194

merged 1 commit into from
Dec 20, 2021

Conversation

pmalek-sumo
Copy link
Contributor

To make it unambiguous let's drop the short versions of those flags:

        --store-logs       Use to store log data which can then be queried via /logs/* endpoints
        --store-metrics    Use to store metrics which will then be returned via /metrics-samples

@pmalek-sumo pmalek-sumo self-assigned this Dec 20, 2021
@pmalek-sumo pmalek-sumo requested a review from a team as a code owner December 20, 2021 12:42
@pmalek-sumo pmalek-sumo enabled auto-merge (squash) December 20, 2021 12:49
@pmalek-sumo pmalek-sumo merged commit 0bc87c2 into main Dec 20, 2021
@pmalek-sumo pmalek-sumo deleted the receiver-mock-remove-duplicated-short-flags branch December 20, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

Assignees

@pmalek-sumo pmalek-sumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmalek-sumo @swiatekm @pmalek