feat(receiver-mock): add querying the spans and traces by span name #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboguszewski-sumo
force-pushed
the
add-name-parameter
branch
from
98e1b6e
to
38a97c3
Compare
sumo-drosiek
reviewed
Sep 9, 2022
src/rust/receiver-mock/README.md
Outdated
| @@ -47,7 +47,7 @@ The following endpoints provide information about received traces: | |||
| It accepts a list of key value pairs being an attribute set that the span will | |||
| have to fullfil in order to be returned. | |||
| Attribute values can be omitted in which case only presence of a particular attribute | |||
| will be checked. | |||
| will be checked. `__name__` is handled specially as it will be matched against the span name. | |||
There was a problem hiding this comment.
I would move it to next line 🤷
sumo-drosiek
reviewed
Sep 9, 2022
Comment on lines
54
to
56
| if span.name == *value { | ||
| continue; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if span.name == *value { | |
| continue; | |
| } else { | |
| return false; | |
| } | |
| if span.name = *value { | |
| continue; | |
| } | |
| return false; |
sumo-drosiek
approved these changes
Sep 9, 2022
aboguszewski-sumo
force-pushed
the
add-name-parameter
branch
from
38a97c3
to
62f85e2
Compare
aboguszewski-sumo
force-pushed
the
add-name-parameter
branch
from
62f85e2
to
e672ea4
Compare
aboguszewski-sumo
force-pushed
the
add-name-parameter
branch
from
e672ea4
to
e1cec7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.