Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template-dependency command #36

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Add template-dependency command #36

merged 3 commits into from
Sep 17, 2020

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Aug 13, 2020

Get override configuration

There could be scenarios when you want to get the configuration of the subcharts (prometheus-operator, fluent-bit, etc.).

Command template-dependency takes part of the upstream values.yaml file basing on the given key:

 kubectl run template-dependency \
  -it --rm \
  --restart=Never -n sumologic \
  --image sumologic/kubernetes-tools \
  -- template-dependency prometheus-operator

This command will return our configuration of prometheus-operator ready to apply for the prometheus-operator helm chart.

You can add additional parameters (like --version=1.0.0) at the end of the command.
List of supported arguments is compatible with helm show values.

Copy link

@perk perk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm the get-override seems a bit detached from the original template command.
I think it should be something like template-dependency.

This way original template gives the whole config while template-dependency gives config for the dependency only.

@sumo-drosiek
Copy link
Contributor Author

It can give you configuration of any part of the values.yaml, not only dependencies

@sumo-drosiek sumo-drosiek changed the title [WIP] Add get-override command [WIP] Add template-dependency command Sep 3, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it now 👍

@sumo-drosiek sumo-drosiek changed the title [WIP] Add template-dependency command Add template-dependency command Sep 14, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek sumo-drosiek merged commit b81d6db into master Sep 17, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-overrides branch September 17, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants