feat(update-collection-v3): add metrics metadata migration #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
swiatekm-sumo
force-pushed
the
feat/metrics-migration
branch
3 times, most recently
from
20570e0
to
8057c04
Compare
src/go/cmd/update-collection-v3/migrations/metrics/metrics_test.go
Outdated
Show resolved
Hide resolved
andrzej-stencel
suggested changes
Nov 25, 2022
There was a problem hiding this comment.
The integration tests for the migration are missing. They are required to make sure that the different integrations don't clash. Please follow point 5. here https://github.com/SumoLogic/sumologic-kubernetes-tools/tree/v2.14.0/src/go/cmd/update-collection-v3#how-to-add-a-new-migration.
swiatekm-sumo
force-pushed
the
feat/metrics-migration
branch
from
7d72e45
to
d09dc74
Compare
andrzej-stencel
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds the scaffolding and migrates
metadata.metrics.configtometadata.metrics.config.mergeas per SumoLogic/sumologic-kubernetes-collection#2622.Ended up having to fix a problem with #387 as well.