receiver-mock: add regex support for querying logs #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboguszewski-sumo
force-pushed
the
add-regex-support
branch
from
af2bb46
to
96c223a
Compare
swiatekm
approved these changes
Nov 22, 2022
src/rust/receiver-mock/Cargo.toml
Outdated
| @@ -29,3 +29,5 @@ itertools = "0.10.5" | |||
| log = "0.4.17" | |||
| simple_logger = "4.0.0" | |||
| hex = "0.4.3" | |||
| regex = "1.7.0" | |||
aboguszewski-sumo
force-pushed
the
add-regex-support
branch
from
96c223a
to
2c6a880
Compare
aboguszewski-sumo
force-pushed
the
add-regex-support
branch
from
2c6a880
to
e792c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to use
fancy-regexcrate instead ofregex, because apparentlyregexdoes not support lookahead in regexes (which is what we really want, because the main point of this feature is to be able to discardundefinedmetadata).Caching of compiled regexes should be definitely added, let me do this in a followup PR.
This feature currently works only for nonotlp logs, but it should be easy to add it for other data types.