-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upgrade_to_v3): add migration for moving configuration keys from Fluentd to sumologic #398
Conversation
1812dbf
to
b72b0fc
Compare
c2345cf
to
1c30fa7
Compare
…Fluentd to sumologic
7c2d88f
to
4b3f848
Compare
4b3f848
to
3e25b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me, just had some nitpicks about naming.
src/go/cmd/update-collection-v3/migrations/fluentd-logs-configs/migrate.go
Outdated
Show resolved
Hide resolved
src/go/cmd/update-collection-v3/migrations/fluentd-logs-configs/fluentd.go
Outdated
Show resolved
Hide resolved
3e25b18
to
b6f1861
Compare
@swiatekm-sumo please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 🙈 about the v2 and v3 names
Personally I mixed feelings about removing v2 an v3 for example here:
this function take |
b6f1861
to
726d55d
Compare
…n for Fluentd logs
726d55d
to
016a91d
Compare
I changed to the "new style" and now all |
Migration for change introduced in SumoLogic/sumologic-kubernetes-collection#2635