feat(update-collection-v3): add migration for FluentD autoscaling #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
feat/update-collection-v3/fluentd-autoscaling
branch
from
56a5856
to
a8c5ff9
Compare
swiatekm
force-pushed
the
feat/update-collection-v3/fluentd-autoscaling
branch
from
a8c5ff9
to
de9fb13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quality of life migration. If the user enabled autoscaling for FluentD, they presumably want it as well for otel. Otherwise we'd instead need to have users take manual steps to enable this, which is less convenient and makes the migration document longer and more complex.
I also fixed a small issue around handling empty structs in a different migration.