feat(update-collection-v3): order output keys based on input #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
feat/update-collection-v3/sort-keys
branch
from
54fc90f
to
14d9c19
Compare
swiatekm
force-pushed
the
feat/update-collection-v3/sort-keys
branch
from
14d9c19
to
9a077db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order the keys in the output yaml based on the input yaml, recursively. Keys which aren't in the input yaml go to the end, and are sorted alphabetically.
I replaced https://pkg.go.dev/gopkg.in/yaml.v3 with https://pkg.go.dev/github.com/goccy/go-yaml to make this relatively painless. As a bonus, it looks like we could preserve comments, although I'd like to try doing that in a separate change.