Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building helm chart v3 migration tool binaries #428

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Building helm chart v3 migration tool binaries #428

merged 1 commit into from
Jan 17, 2023

Conversation

rnishtala-sumo
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo commented Jan 17, 2023 •
edited
Loading

Building helm chart v3 migration tool binaries

Binaries from a test run can be found below:
https://github.com/SumoLogic/sumologic-kubernetes-tools/actions/runs/3941261582

@rnishtala-sumo rnishtala-sumo force-pushed the rnishtala-migration-tool-binaries branch 3 times, most recently from 83528de to 56c95f7 Compare January 17, 2023 01:55
@rnishtala-sumo rnishtala-sumo marked this pull request as ready for review January 17, 2023 01:58
@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner January 17, 2023 01:58
@rnishtala-sumo rnishtala-sumo force-pushed the rnishtala-migration-tool-binaries branch 5 times, most recently from 9de11ed to b8cf4be Compare January 17, 2023 02:20
sumo-drosiek
sumo-drosiek approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally

swiatekm
swiatekm approved these changes Jan 17, 2023
View reviewed changes
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say to update release.md, but it looks like we don't have it in this repo. Should be added in a separate PR.

@rnishtala-sumo rnishtala-sumo force-pushed the rnishtala-migration-tool-binaries branch 9 times, most recently from ce697d8 to 3b91ff0 Compare January 17, 2023 16:05
@rnishtala-sumo
Copy link
Contributor Author

rnishtala-sumo commented Jan 17, 2023 •
edited
Loading

After adding a loop in the makefile to support all 6 distributions, the artifacts from a test run is below:
https://github.com/SumoLogic/sumologic-kubernetes-tools/actions/runs/3941261582

@rnishtala-sumo rnishtala-sumo force-pushed the rnishtala-migration-tool-binaries branch 3 times, most recently from 6d32ecd to fff9180 Compare January 17, 2023 16:28
@rnishtala-sumo rnishtala-sumo force-pushed the rnishtala-migration-tool-binaries branch from fff9180 to 41984fc Compare January 17, 2023 16:30
@rnishtala-sumo rnishtala-sumo merged commit 58b648c into main Jan 17, 2023
@rnishtala-sumo rnishtala-sumo deleted the rnishtala-migration-tool-binaries branch January 17, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnishtala-sumo @sumo-drosiek @swiatekm