Profile code #19
Open
Profile code #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshu219
reviewed
May 21, 2024
himanshu219
reviewed
May 21, 2024
himanshu219
reviewed
May 21, 2024
| payload, state = self.transform_data(content) | ||
| #Todo Make this atomic if after sending -> Ctrl - C happens then it fails to save state |
There was a problem hiding this comment.
why are we removing existing comments ?
There was a problem hiding this comment.
Have restore the comments
himanshu219
reviewed
May 21, 2024
himanshu219
reviewed
May 21, 2024
| self.log.info(f'''No results window LogType: {log_type} kwargs: {kwargs} status: {fetch_success}''') | ||
| is_move_fetch_window, new_state = self.check_move_fetch_window(kwargs) | ||
| if is_move_fetch_window: | ||
| self.save_state(**new_state) | ||
| self.log.debug(f'''Moving fetched window newstate: {new_state}''') | ||
| else: | ||
| self.log.error(f'''Error LogType: {log_type} status: {fetch_success} reason: {content}''') | ||
| except Exception as e: |
There was a problem hiding this comment.
remove try and except, the exceptions should be propagated to base class where these are caught.
himanshu219
reviewed
May 21, 2024
sumomongodbatlascollector/api.py
Outdated
|
|
||
| msg['project_id'] = self.api_config['PROJECT_ID'] |
There was a problem hiding this comment.
revert back this change, the older if conditions were there for different mongodb versions which have different log format.
himanshu219
reviewed
May 21, 2024
himanshu219
reviewed
May 21, 2024
himanshu219
requested changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added the profiling code for the classes and methods of the api and the main file. The code profiles each line of each of the function and generates html (flamegraph profile) for each of the functions.