New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build UBI-based image #1440
Conversation
I disagree, anything we build for releases should also be built for dev. Otherwise we're never going to catch breakage. The approach in this PR looks reasonable to me in general. |
Can we rename it in this PR, or another one and merge it before this PR? |
I agree we should build, but we probably don't need to push the non-release UBI images to an image repository, right? |
We currently do it for all builds on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although we should add UBI FIPS images in a subsequent PR.
This is more like a PoC than ready PR:
LATEST_TAG_FIPS_SUFFIX
was used as a temporal solution: imo we should rename it just toLATEST_TAG_SUFFIX
and use it as usual