Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build UBI-based image #1440

Merged
merged 19 commits into from Feb 20, 2024
Merged

feat: build UBI-based image #1440

merged 19 commits into from Feb 20, 2024

Conversation

aboguszewski-sumo
Copy link
Contributor

This is more like a PoC than ready PR:

  • only linux/amd64 was added
  • dev builds are only to confirm that it builds successfully: IMO we should only have this enabled for releases
  • LATEST_TAG_FIPS_SUFFIX was used as a temporal solution: imo we should rename it just to LATEST_TAG_SUFFIX and use it as usual

@aboguszewski-sumo aboguszewski-sumo requested a review from a team as a code owner February 8, 2024 14:59
@swiatekm-sumo
Copy link
Contributor

dev builds are only to confirm that it builds successfully: IMO we should only have this enabled for releases

I disagree, anything we build for releases should also be built for dev. Otherwise we're never going to catch breakage.

The approach in this PR looks reasonable to me in general.

@sumo-drosiek
Copy link
Contributor

* `LATEST_TAG_FIPS_SUFFIX` was used as a temporal solution: imo we should rename it just to `LATEST_TAG_SUFFIX` and use it as usual

Can we rename it in this PR, or another one and merge it before this PR?

@andrzej-stencel
Copy link
Contributor

dev builds are only to confirm that it builds successfully: IMO we should only have this enabled for releases

I disagree, anything we build for releases should also be built for dev. Otherwise we're never going to catch breakage.

I agree we should build, but we probably don't need to push the non-release UBI images to an image repository, right?

Dockerfile_ubi Outdated Show resolved Hide resolved
Dockerfile_ubi Outdated Show resolved Hide resolved
@swiatekm-sumo
Copy link
Contributor

dev builds are only to confirm that it builds successfully: IMO we should only have this enabled for releases

I disagree, anything we build for releases should also be built for dev. Otherwise we're never going to catch breakage.

I agree we should build, but we probably don't need to push the non-release UBI images to an image repository, right?

We currently do it for all builds on main, which I think is valid, as it makes it much easier to run external tests on dev versions.

Dockerfile_ubi Outdated Show resolved Hide resolved
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we should add UBI FIPS images in a subsequent PR.

@aboguszewski-sumo aboguszewski-sumo enabled auto-merge (squash) February 20, 2024 08:05
@aboguszewski-sumo aboguszewski-sumo merged commit 28d1a7f into main Feb 20, 2024
47 checks passed
@aboguszewski-sumo aboguszewski-sumo deleted the dev-build/ab-ubi-image branch February 20, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants