Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing configproviders (httpprovider, httpsprovider, yamlprovider) #1528

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

sumo-drosiek
Copy link
Contributor

No description provided.

…rovider)

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner April 8, 2024 11:54
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@swiatekm
Copy link

swiatekm commented Apr 9, 2024

@sumo-drosiek can you rebase on #1530 ?

@@ -0,0 +1 @@
feat: add missing configproviders (httpprovider, httpsprovider, yamlprovider)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems yamlprovider was not missing however? 🤔

Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the changelog note as per @echlebek 's comment.

@sumo-drosiek sumo-drosiek enabled auto-merge (squash) April 10, 2024 08:11
@sumo-drosiek sumo-drosiek merged commit 6fd8997 into main Apr 10, 2024
30 checks passed
@sumo-drosiek sumo-drosiek deleted the drosiek-missing-config-providers branch April 10, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants