Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backoff #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement backoff #45

wants to merge 4 commits into from

Conversation

akdor1154
Copy link

This implements exponential backoff for all Sumologic API calls.

There is also a fix for the endpoint patch that made its way in recently that didn't seem to be tested properly (ping @mccartney), this and a whitespace fix are in separate commits, hope that's OK.

Cheers
Jarrad

@akdor1154
Copy link
Author

This should fix #3 .

@rickjuryxero
Copy link

this is a great idea - we have been having rate limiting issues trying to build something on top of this sdk. It would be great to have this fixed inside the python sdk

@himanshu219
Copy link
Contributor

Actually request library itself implements exponential backoff we need to pass few parameters to it. Though the solution looks good any specific reason for creating the custom backoff function instead of using builtin solution https://www.peterbe.com/plog/best-practice-with-retries-with-requests

@akdor1154
Copy link
Author

Oh cool. Happy to go with whatever Sumo team prefer.

@dspruell-s01
Copy link

Looking at implementing an API client integration with this library - any prospects for having this bumped/merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants