Better handling for startupProbe and livenessProbe #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
reviewed
Apr 6, 2021
operator/handler/handler.go
Outdated
| @@ -63,7 +63,10 @@ type PodExtender struct { | |||
|
|
|||
| // Handle handles requests to create/update Pod and extends it by adding tailing sidecars | |||
| func (e *PodExtender) Handle(ctx context.Context, req admission.Request) admission.Response { | |||
| if req.Operation == admv1.Delete { | |||
|
|
|||
operator/handler/handler.go
Outdated
Comment on lines
67
to
69
| if req.Operation == "" { | ||
| return admission.Allowed("Received startupProbe/livenessProbe") | ||
| } else if req.Operation == admv1.Delete { |
There was a problem hiding this comment.
Nit: I'd personally not join those cases in 1 if block.
andrzej-stencel
approved these changes
Apr 6, 2021
kkujawa-sumo
force-pushed
the
kk-handling-probes
branch
from
05e6313
to
aa22248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper json request should have appropriate HTTP header:
this eliminates following error in operator logs:
2021-04-06T10:59:12.161Z ERROR controller-runtime.webhook.webhooks unable to process a request with an unknown content type {"webhook": "/add-tailing-sidecars-v1-pod", "content type": "", "error": "contentType=, expected application/json"}Add better handling for startupProbe and livenessProbe in operator code to eliminate this errror:
2021-04-06T11:23:46.412Z DEBUG controller-runtime.webhook.webhooks wrote response {"webhook": "/add-tailing-sidecars-v1-pod", "code": 400, "reason": "", "UID": "", "allowed": false}