added some mappers #295
Closed
added some mappers #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annstriganova
requested changes
May 16, 2024
There was a problem hiding this comment.
Thank you for improving the test coverage and for making the code less cumbersome by adding the generated converters ❤️
I would like you to take a look at the failing test - this is the only serious blocker. If you have resources, take a look at other comments as well, but remember that "nitpicking" notes are optional 👍
src/main/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverter.java
Outdated
Show resolved
Hide resolved
src/test/java/com/zufar/icedlatte/favorite/converter/FavoriteItemDtoConverterTest.java
Show resolved
Hide resolved
src/test/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/zufar/icedlatte/review/api/ProductAverageRatingProviderTest.java
Outdated
Show resolved
Hide resolved
...test/java/com/zufar/icedlatte/favorite/converter/ListOfFavoriteProductsDtoConverterTest.java
Show resolved
Hide resolved
annstriganova
requested changes
May 20, 2024
src/test/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/zufar/icedlatte/review/api/ProductAverageRatingProviderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/zufar/icedlatte/favorite/converter/FavoriteItemDtoConverterTest.java
Show resolved
Hide resolved
…-mapstruct' into feature/IL-287-custom-mappers-to-mapstruct # Conflicts: # src/main/java/com/zufar/icedlatte/review/api/ProductReviewsStatisticsProvider.java
annstriganova
added a commit
that referenced
this pull request
May 26, 2024
…to-mapstruct-clone COPY of #295: added some mappers by Victoria Ziborova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.