added some mappers

src/main/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverter.java

@@ -7,7 +7,12 @@
 import com.zufar.icedlatte.openapi.dto.ProductInfoDto;
 import com.zufar.icedlatte.product.entity.ProductInfo;
 import com.zufar.icedlatte.user.entity.UserEntity;
-import org.mapstruct.*;
+import org.mapstruct.InjectionStrategy;
+import org.mapstruct.Mapper;
+import org.mapstruct.MappingConstants;
+import org.mapstruct.ReportingPolicy;
+import org.mapstruct.Mapping;
+import org.mapstruct.Named;
 
 import java.util.Optional;
 import java.util.UUID;
@@ -16,22 +21,11 @@
         uses = FavoriteItemDtoConverter.class, unmappedTargetPolicy = ReportingPolicy.IGNORE, injectionStrategy = InjectionStrategy.FIELD)
 public interface FavoriteListDtoConverter {
 
-    @Mapping(target = "id", source = "id")
     @Mapping(target = "userId", source = "user", qualifiedByName = "toUserId")
-    @Mapping(target = "updatedAt", source = "updatedAt")
     @Mapping(target = "favoriteItems", source = "favoriteItems", qualifiedByName = "mapFavoriteItems")
     FavoriteListDto toDto(final FavoriteListEntity favoriteListEntity);
 
     @Mapping(target = "id", source = "productId")
-    @Mapping(target = "name", source = "name")
-    @Mapping(target = "description", source = "description")
-    @Mapping(target = "price", source = "price")
-    @Mapping(target = "quantity", source = "quantity")
-    @Mapping(target = "active", source = "active")
-    @Mapping(target = "averageRating", source = "averageRating")
-    @Mapping(target = "reviewsCount", source = "reviewsCount")
-    @Mapping(target = "brandName", source = "brandName")
-    @Mapping(target = "sellerName", source = "sellerName")
     ProductInfoDto convertProductInfoDto(ProductInfo productInfo);
 
     @Named("toUserId")

src/main/java/com/zufar/icedlatte/favorite/converter/ListOfFavoriteProductsDtoConverter.java

@@ -4,7 +4,12 @@
 import com.zufar.icedlatte.favorite.dto.FavoriteListDto;
 import com.zufar.icedlatte.openapi.dto.ListOfFavoriteProductsDto;
 import com.zufar.icedlatte.openapi.dto.ProductInfoDto;
-import org.mapstruct.*;
+import org.mapstruct.InjectionStrategy;
+import org.mapstruct.Mapper;
+import org.mapstruct.MappingConstants;
+import org.mapstruct.ReportingPolicy;
+import org.mapstruct.Mapping;
+import org.mapstruct.Named;
 
 import java.util.List;
 import java.util.Set;

src/main/java/com/zufar/icedlatte/review/api/ProductAverageRatingProvider.java

@@ -14,6 +14,7 @@
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
+import java.util.Locale;
 import java.util.UUID;
 
 @Slf4j
@@ -37,7 +38,7 @@ public ProductReviewRatingStats getRatingAndReviewStat(final UUID productId) {
             log.error("The product with productId = {} was not found.", productId);
             throw new ProductNotFoundException(productId);
         }
-        String formattedAvgRating = String.format("%.1f", avgRating);
+        String formattedAvgRating = String.format(Locale.US, "%.1f", avgRating);
         Integer reviewsCount = reviewRepository.getReviewCountProductById(productId);
         RatingMap productRatingMap = productReviewDtoConverter.convertToProductRatingMap(productRatingCountPairs);
 

src/main/java/com/zufar/icedlatte/review/converter/ProductReviewDtoConverter.java

@@ -6,7 +6,12 @@
 import com.zufar.icedlatte.review.dto.ProductRatingCount;
 import com.zufar.icedlatte.review.entity.ProductReview;
 import com.zufar.icedlatte.user.entity.UserEntity;
-import org.mapstruct.*;
+import org.mapstruct.InjectionStrategy;
+import org.mapstruct.Mapper;
+import org.mapstruct.Mapping;
+import org.mapstruct.Named;
+import org.mapstruct.MappingConstants;
+import org.mapstruct.ReportingPolicy;
 import org.springframework.data.domain.Page;
 
 import java.util.List;
@@ -16,18 +21,12 @@
         uses = ProductReviewDtoConverter.class, unmappedTargetPolicy = ReportingPolicy.IGNORE, injectionStrategy = InjectionStrategy.FIELD)
 public interface ProductReviewDtoConverter {
 
-    ProductReviewDto EMPTY_PRODUCT_REVIEW_RESPONSE =
+   public static final ProductReviewDto EMPTY_PRODUCT_REVIEW_RESPONSE =
             new ProductReviewDto(null, null, null, null, null, null, null, null, null);
 
     @Mapping(target = "productReviewId", source = "id")
-    @Mapping(target = "productId", source = "productId")
-    @Mapping(target = "productRating", source = "productRating")
-    @Mapping(target = "text", source = "text")
-    @Mapping(target = "createdAt", source = "createdAt")
     @Mapping(target = "userName", source = "user", qualifiedByName = "toUserName")
     @Mapping(target = "userLastname", source = "user", qualifiedByName = "toUserLastName")
-    @Mapping(target = "likesCount", source = "likesCount")
-    @Mapping(target = "dislikesCount", source = "dislikesCount")
     ProductReviewDto toProductReviewDto(ProductReview productReview);
 
     @Mapping(target = "page", expression = "java(page.getTotalPages())")

src/test/java/com/zufar/icedlatte/favorite/converter/FavoriteListDtoConverterTest.java

@@ -1,5 +1,6 @@
 package com.zufar.icedlatte.favorite.converter;
 
+import com.zufar.icedlatte.favorite.dto.FavoriteItemDto;
 import com.zufar.icedlatte.favorite.dto.FavoriteListDto;
 import com.zufar.icedlatte.favorite.entity.FavoriteItemEntity;
 import com.zufar.icedlatte.favorite.entity.FavoriteListEntity;
@@ -18,6 +19,7 @@
 import java.util.UUID;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class FavoriteListDtoConverterTest {
 
@@ -47,12 +49,9 @@ void convertListEntityToDto() {
 
         FavoriteListDto actualFavoriteListDto = converter.toDto(expectedFavoriteListEntity);
 
-        assertThat(actualFavoriteListDto.id()).isEqualTo(expectedFavoriteListEntity.getId());
-        assertThat(actualFavoriteListDto.updatedAt()).isEqualTo(expectedFavoriteListEntity.getUpdatedAt());
-        assertThat(actualFavoriteListDto.userId()).isEqualTo(Optional.of(expectedFavoriteListEntity.getUser()).get().getId());
-        // fIXME: how to test favoriteItems?
-//        assertThat(actualFavoriteListDto.favoriteItems()).isEqualTo(expectedFavoriteListEntity.getFavoriteItems());
-
+        assertEquals(actualFavoriteListDto.id(), expectedFavoriteListEntity.getId());
+        assertEquals(actualFavoriteListDto.updatedAt(), expectedFavoriteListEntity.getUpdatedAt());
+        assertEquals(actualFavoriteListDto.userId(), Optional.of(expectedFavoriteListEntity.getUser()).get().getId());
     }
 
     @Test

src/test/java/com/zufar/icedlatte/favorite/converter/ListOfFavoriteProductsDtoConverterTest.java

@@ -14,6 +14,7 @@
 import java.util.UUID;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class ListOfFavoriteProductsDtoConverterTest {
 
@@ -44,5 +45,7 @@ void toListProductDto() {
         ListOfFavoriteProductsDto actualListOfFavoriteProductsDto = converter.toListProductDto(expectedFavoriteListDto);
 
         assertThat(actualListOfFavoriteProductsDto.getProducts()).isEqualTo(converter.toProductInfoDto(expectedFavoriteListDto.favoriteItems()));
+
+        assertEquals(actualListOfFavoriteProductsDto.getProducts().get(0), productInfoDto);
     }
 }

src/test/java/com/zufar/icedlatte/review/api/ProductAverageRatingProviderTest.java

@@ -52,7 +52,7 @@ void getRatingAndReviewStatsSuccessful() {
         var reviewsCount = 0;
 
         var expectedRatingMap = new RatingMap(1, 0, 0, 0, 0);
-        var expectedStats = new ProductReviewRatingStats(randomID, "0,0", reviewsCount, expectedRatingMap);
+        var expectedStats = new ProductReviewRatingStats(randomID, "0.0", reviewsCount, expectedRatingMap);
         when(reviewRepository.getRatingsMapByProductId(randomID)).thenReturn(listOfMappings);
         when(reviewRepository.getAvgRatingByProductId(randomID)).thenReturn(0.0);
         when(reviewRepository.getReviewCountProductById(randomID)).thenReturn(reviewsCount);