Added cashier shift capability & Check shift capabilities on user self registration. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a form to edit user shift capabilities. Only allow self registration for flying shifts if the user has the appropriate capability. Updated populate function to give random shift capabilities to some users.
leonhandreke
approved these changes
Sep 7, 2021
tapir/shifts/models.py
Outdated
| @@ -17,10 +17,12 @@ | |||
|
|
|||
| class ShiftUserCapability: | |||
| SHIFT_COORDINATOR = "shift_coordinator" | |||
| TRAINED_CASHIER = "trained_cashier" | |||
There was a problem hiding this comment.
(nit) Maybe make this just CASHIER? Shift Coordinators are also trained...
tapir/shifts/views.py
Outdated
| @@ -82,6 +83,7 @@ def get_context_data(self, **kwargs): | |||
| for slot in slots: | |||
| slot.can_register = slot.user_can_attend(self.request.user) | |||
| context["slots"] = slots | |||
| context["shift_is_in_the_future"] = context["shift"].start_time > timezone.now() | |||
There was a problem hiding this comment.
We'll need this in quite a few places, maybe we can just make this a model method? Sort of hacky though..
… in the Shift model.
|
I keep trying to find out why I wrote "Check shift capabilities" but I have no idea... |
|
Ah I think I got it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I just wanted to check that this is what you intended with the shift capabilities.