Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default colormap and default parameter to velocity #25

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

mts299
Copy link
Contributor

@mts299 mts299 commented Dec 17, 2019

As requested in #24 the new default parameter is v Velocity and the new default colormap is the PydDARN Velocity colormap. To keep with the majority of what users plot and with the velocity colormap convention.

import pydarn
import matplotlib.pyplot as plt 

fitacf_file = "20180101.C0.cly.fitacf"
darn_read = pydarn.SDarnRead(fitacf_file)
fitacf_data = darn_read.read_fitacf()
pydarn.RTP.plot_range_time(fitacf_data, zmin=-600, zmax=600)
plt.show()

RTI_velocity

Granted this has one caveat with the other parameters:
RTI_power

However, they can change colormaps flexibly:

import pydarn
import matplotlib.pyplot as plt 

fitacf_file = "20180101.C0.cly.fitacf"
darn_read = pydarn.SDarnRead(fitacf_file)
fitacf_data = darn_read.read_fitacf()
pydarn.RTP.plot_range_time(fitacf_data, parameter='p_l', cmap='plasma')
plt.show()

RTI_plasma_SNR

@billetd if you don't mind updating plot_range_time tutorials again to update with the new changes and mention that if users wish to use another colormap for parameters like p_l Signal to Noise with some suggestions.

@asreimer
Copy link
Contributor

asreimer commented Dec 17, 2019 via email

@mts299 mts299 added this to TO DOs in pyDARN v 1.0 via automation Dec 17, 2019
@mts299 mts299 added the default change Changing a default value label Dec 17, 2019
@billetd billetd mentioned this pull request Dec 20, 2019
@mts299 mts299 added this to the 1.0.0 milestone Jan 3, 2020
@billetd
Copy link
Contributor

billetd commented Jan 15, 2020

PR #31 on documentation has been updated to include the new colourmap and defaults here, but can't be merged till this is ;).

I've been using this branch for a while now and haven't ran into any issues. I like the default colourmap alot and am happy for default RTP to be velocity.

@billetd billetd merged commit 1a88548 into develop Jan 15, 2020
@mts299 mts299 deleted the rtp/default_colormap_fix branch January 15, 2020 21:10
mts299 pushed a commit that referenced this pull request Feb 5, 2020
changed default colormap and default parameter to velocity
mts299 pushed a commit that referenced this pull request Feb 26, 2020
changed default colormap and default parameter to velocity
mts299 pushed a commit that referenced this pull request Feb 26, 2020
changed default colormap and default parameter to velocity
mts299 pushed a commit that referenced this pull request Feb 26, 2020
changed default colormap and default parameter to velocity
mts299 pushed a commit that referenced this pull request Feb 26, 2020
changed default colormap and default parameter to velocity
mts299 pushed a commit that referenced this pull request Mar 25, 2020
changed default colormap and default parameter to velocity
mardet987 pushed a commit that referenced this pull request Mar 26, 2020
changed default colormap and default parameter to velocity

Former-commit-id: 1a88548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
default change Changing a default value
Projects
No open projects
pyDARN v 1.0
  
TO DOs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants