-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed default colormap and default parameter to velocity #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to clarify, I think the issue I raised was invalid.
If it is expected that most people will use plot_range_time to plot
velocity first, then this default change makes a lot of sense!
I can test and merge when I get to a computer.
…On Tue, Dec 17, 2019, 08:37 Marina Schmidt ***@***.***> wrote:
As requested in #24 <#24> the
new default parameter is v Velocity and the new default colormap is the
PydDARN Velocity colormap. To keep with the majority of what users plot and
with the velocity colormap convention.
import pydarn
import matplotlib.pyplot as plt
fitacf_file = "20180101.C0.cly.fitacf"
darn_read = pydarn.SDarnRead(fitacf_file)
fitacf_data = darn_read.read_fitacf()
pydarn.RTP.plot_range_time(fitacf_data, zmin=-600, zmax=600)
plt.show()
[image: RTI_velocity]
<https://user-images.githubusercontent.com/6520530/71014924-59bf4500-20b8-11ea-8494-d6bb8da1806a.png>
Granted this has one caveat with the other parameters:
[image: RTI_power]
<https://user-images.githubusercontent.com/6520530/71015077-a1de6780-20b8-11ea-9f64-fdb54d287861.png>
However, they can change colormaps flexibly:
import pydarn
import matplotlib.pyplot as plt
fitacf_file = "20180101.C0.cly.fitacf"
darn_read = pydarn.SDarnRead(fitacf_file)
fitacf_data = darn_read.read_fitacf()
pydarn.RTP.plot_range_time(fitacf_data, parameter='p_l', cmap='plasma')
plt.show()
[image: RTI_plasma_SNR]
<https://user-images.githubusercontent.com/6520530/71015379-1ca78280-20b9-11ea-941a-8987a41ca8f0.png>
@billetd <https://github.com/billetd> if you don't mind updating
plot_range_time tutorials again to update with the new changes and
mention that if users wish to use another colormap for parameters like p_l
Signal to Noise with some suggestions.
------------------------------
You can view, comment on, or merge this pull request online at:
#25
Commit Summary
- changed default colormap and default parameter to velocity
File Changes
- *M* pydarn/plotting/rtp.py
<https://github.com/SuperDARN/pydarn/pull/25/files#diff-0> (8)
Patch Links:
- https://github.com/SuperDARN/pydarn/pull/25.patch
- https://github.com/SuperDARN/pydarn/pull/25.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25?email_source=notifications&email_token=ABDEHEYEKA7C73DEXVBTKGTQZD535A5CNFSM4J36IGP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IBDIHOA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDEHE2N7VDSY7A3SFH5SRTQZD535ANCNFSM4J36IGPQ>
.
|
Merged
PR #31 on documentation has been updated to include the new colourmap and defaults here, but can't be merged till this is ;). I've been using this branch for a while now and haven't ran into any issues. I like the default colourmap alot and am happy for default RTP to be velocity. |
aburrell
approved these changes
Jan 15, 2020
mts299
pushed a commit
that referenced
this pull request
Feb 5, 2020
changed default colormap and default parameter to velocity
mts299
pushed a commit
that referenced
this pull request
Feb 26, 2020
changed default colormap and default parameter to velocity
mts299
pushed a commit
that referenced
this pull request
Feb 26, 2020
changed default colormap and default parameter to velocity
mts299
pushed a commit
that referenced
this pull request
Feb 26, 2020
changed default colormap and default parameter to velocity
mts299
pushed a commit
that referenced
this pull request
Feb 26, 2020
changed default colormap and default parameter to velocity
mts299
pushed a commit
that referenced
this pull request
Mar 25, 2020
changed default colormap and default parameter to velocity
mardet987
pushed a commit
that referenced
this pull request
Mar 26, 2020
changed default colormap and default parameter to velocity Former-commit-id: 1a88548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #24 the new default parameter is
v
Velocity and the new default colormap is the PydDARN Velocity colormap. To keep with the majority of what users plot and with the velocity colormap convention.Granted this has one caveat with the other parameters:
![RTI_power](https://user-images.githubusercontent.com/6520530/71015077-a1de6780-20b8-11ea-9f64-fdb54d287861.png)
However, they can change colormaps flexibly:
@billetd if you don't mind updating
plot_range_time
tutorials again to update with the new changes and mention that if users wish to use another colormap for parameters likep_l
Signal to Noise with some suggestions.