Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation before 1.0 Release #207

Closed
13 of 14 tasks
Noah-Silvera opened this issue Oct 17, 2022 · 7 comments
Closed
13 of 14 tasks

Documentation before 1.0 Release #207

Noah-Silvera opened this issue Oct 17, 2022 · 7 comments

Comments

@Noah-Silvera
Copy link
Member

Noah-Silvera commented Oct 17, 2022

Table of all available configuration options

Nexuses

  • The nexus sync button and when to use it.

Reporting

  • Walkthrough - how do you setup reporting/go through backfill/confirm it works
  • When does a transaction get reported
  • When does a refund transaction get reported
  • Note that reporting is turned off by default.
  • Why order-level adjustments are unsupported
  • Backfilling historical orders safely

Changelog

  • Pull breaking changes out of changelog into release notes
  • Refactor changelog to be more organized
  • Bug fixes, breaking changes, new features, high level summary. Re: Solidus or other projects

Other

  • Note that purchasing gift cards is not taxable, do not report them.
@Noah-Silvera
Copy link
Member Author

Note: We should probably put this stuff in the wiki

Someone will have to refactor the Readme to move non-relevant documentation into the wiki

@benjaminwil
Copy link
Member

Note: We should probably put this stuff in the wiki

For now, I've made a pull request, #210, to add the configuration settings to the README.

One thing I don't like about GitHub wikis is that there's no way to version them alongside the code. For developer configuration settings, at least, this makes me think the README, or some other committed document, is the best place to describe the settings.

For reporting interface usage and documentation–the wiki might be a more appropriate place.

@benjaminwil
Copy link
Member

Added an item to the list in the original issue post: "Nexus sync button and when to use it."

@forkata forkata moved this from Backlog to In progress in TaxJar Reporting (1.0 release) Apr 5, 2023
@benjaminwil
Copy link
Member

Just refactored the list and checked off things that are documented in the README and on the wiki already.

@benjaminwil
Copy link
Member

Add a warning about using the taxable_order_hook

@Noah-Silvera I am not sure how to document this. From the original ticket it seems like you have an idea of how to.

@benjaminwil
Copy link
Member

Note that purchasing gift cards is not taxable, do not report them.

@forkata @Noah-Silvera Is this in-scope? Solidus doesn't provide gift cards by default, so I think it would be up to each store and its development team to handle this their own way.

@forkata
Copy link
Collaborator

forkata commented Dec 11, 2023

@benjaminwil I don't think GC's are in scope since like you said it's not a feature Solidus provides out of the box.

benjaminwil added a commit that referenced this issue Jan 31, 2024
This resolves the remaining checklist items in issue #207.

Closes #207.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants