Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running DOjS with modified EXE name does not work #22

Closed
SuperIlu opened this issue Apr 30, 2022 · 6 comments
Closed

Running DOjS with modified EXE name does not work #22

SuperIlu opened this issue Apr 30, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@SuperIlu
Copy link
Owner

SuperIlu commented Apr 30, 2022

In theory it should be possible to rename DOJS.EXE and JSBOOT.ZIP to, lets say, FOO.EXE and FOO.ZIP.
Running FOO.EXE without additional parameters should run the script MAIN.JS in the FOO.ZIP.
This does not work because DOjS still searches for the bootfiles in JSBOOT.ZIP instead of FOO.ZIP.

@SuperIlu
Copy link
Owner Author

SuperIlu commented Jul 3, 2022

Will be fixed in V1.9.0

@SuperIlu SuperIlu added this to the v1.9.0 release milestone Oct 23, 2022
@dr-hansen
Copy link

I tried upgrading my project to 1.9.1. Is there a change to zip file structure expectations? Prior setup didn't work and confused if I need to do something different with JSBOOT to get things working again. My exe and zip filenames match and I'm either getting a Script Not Found at startup or e.g., cannot open file 'c:/xmarks.ZIP=JSBOOT/func.js' in JSLOG. Thoughts?

@SuperIlu SuperIlu reopened this Dec 8, 2022
@SuperIlu
Copy link
Owner Author

SuperIlu commented Dec 8, 2022

Hmm, I think I tested all different possibilities regarding EXE and ZIP files, but with DOStodon I noticed it doesn't work when additional command line parameters are needed.

If you don't use parameters it would be nice if you could provide me with an example to reproduce the problem...

@dr-hansen
Copy link

Even with no parameters. I'll DM you on discoord ...succulentbacon

@SuperIlu SuperIlu added the bug Something isn't working label Dec 10, 2022
@SuperIlu
Copy link
Owner Author

using the "EXE and JSBOOT rename feature" leads to memory corruption in DOS memory due to an out-of-bounds write.
re-starting DOjS then leads to weird behavior at start-up

will be fixed in v1.10

@SuperIlu
Copy link
Owner Author

fixed in v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants